Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previous implementation of parca manifests #570

Merged
merged 8 commits into from
Aug 2, 2023

Conversation

coleenquadros
Copy link
Contributor

@coleenquadros coleenquadros commented Jul 31, 2023

We have added parca to the observatorium-tools namespace and moved to meta monitoring directory. This PR is to clean up the old implementation for parca
https://issues.redhat.com/browse/RHOBS-772

@philipgough
Copy link
Contributor

@coleenquadros I think we can remove the jsonnet import for the bundler also if it is going to be unused

@vprashar2929
Copy link
Contributor

Hey @coleenquadros after this PR merge can you do a rebase?

Copy link
Contributor

@vprashar2929 vprashar2929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipgough philipgough merged commit 469a134 into rhobs:main Aug 2, 2023
1 check passed
@coleenquadros coleenquadros deleted the parca_rearch branch August 2, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants