[rhobs]: Add rhobs query #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
philipgough
reviewed
Nov 24, 2023
| name: observatorium-thanos-query-rule-default | ||
| objects: | ||
| - apiVersion: route.openshift.io/v1 | ||
| kind: Route |
There was a problem hiding this comment.
I am trying to understand why we expose this directly via the internet? Is it for us (rhobs) to access the Thanos UI?
There was a problem hiding this comment.
Yes this is what I was thinking, for debugging purpose
philipgough
reviewed
Nov 24, 2023
...rvices/app-sre-stage-01/rhobs/default/observatorium-metrics-query-rule-default-template.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds thanos query deployment to rhobs