Add cnv_abnormal metric #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configuration/telemeter/metrics.json
Outdated
| "{__name__=\"hostedcluster:hypershift_cluster_vcpus:max\"}", | ||
| "{__name__=\"hypershift_cluster_cores\"}", |
There was a problem hiding this comment.
not sure why the generation moved this line but it fails the CI.
There was a problem hiding this comment.
I reverted everything and then run make all I didn't even added cnv_abnormal manually
|
do we need to add the metric to resources/services/telemeter-template.yaml? see PR: #686 |
avlitman
force-pushed
the
add-cnv-abnormal
branch
from
3aa9048
to
85e9b78
Compare
Signed-off-by: avlitman <[email protected]>
avlitman
force-pushed
the
add-cnv-abnormal
branch
from
85e9b78
to
3720ee0
Compare
|
closing since #690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cnv_abnormal added to telemeter: openshift/cluster-monitoring-operator#2291.
This pr adding the metric to telemeter server metrics allow list.