Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use go version in go.mod file #350

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jan--f
Copy link
Collaborator

@jan--f jan--f commented Sep 1, 2023

And drop use of .github/env.

@jan--f jan--f requested a review from a team as a code owner September 1, 2023 08:43
danielmellado
danielmellado previously approved these changes Sep 1, 2023
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Seems pretty straightforward and I also prefer to use go.mod directly now that it's available!

@jan--f
Copy link
Collaborator Author

jan--f commented Sep 1, 2023

/skip

sthaha
sthaha previously approved these changes Sep 4, 2023
Copy link
Collaborator

@sthaha sthaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@simonpasquier
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved label Sep 4, 2023
@jan--f jan--f dismissed stale reviews from sthaha and danielmellado via ab90d1e September 5, 2023 07:08
@jan--f jan--f force-pushed the ci-use-go.mod-version branch from 5b1271f to ab90d1e Compare September 5, 2023 07:08
@openshift-ci openshift-ci bot removed the lgtm label Sep 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier,sthaha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielmellado
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit b6b11bb into rhobs:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants