Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bundle dockerfile is needed for prow job #360

Merged

Conversation

lihongyan1
Copy link
Contributor

@lihongyan1 lihongyan1 commented Sep 18, 2023

Submit then bundle.Dockerfile.

Checked several operator repositories, they contain the docker file, such as
https://github.com/openshift/open-telemetry-opentelemetry-operator

@lihongyan1 lihongyan1 requested a review from a team as a code owner September 18, 2023 09:25
@lihongyan1 lihongyan1 requested review from jan--f and JoaoBraveCoding and removed request for a team September 18, 2023 09:25
@lihongyan1 lihongyan1 force-pushed the ci-prow-add-bundle-dockerfile branch 2 times, most recently from a3f9975 to 9997fec Compare September 18, 2023 09:42
@lihongyan1 lihongyan1 changed the title Set up presubmit prow job to run test on OCP, bundle.Dockerfile is ne… ci: bundle.Dockerfile is needed for presubmit prow job Sep 18, 2023
@lihongyan1 lihongyan1 changed the title ci: bundle.Dockerfile is needed for presubmit prow job ci: bundle dockerfile is needed for presubmit prow job Sep 18, 2023
@lihongyan1 lihongyan1 force-pushed the ci-prow-add-bundle-dockerfile branch from 9997fec to 54216d4 Compare September 18, 2023 09:53
Submit then bundle.Dockerfile.

Checked several operator repositories, they contain the docker file, such as
https://github.com/openshift/open-telemetry-opentelemetry-operator
@lihongyan1 lihongyan1 force-pushed the ci-prow-add-bundle-dockerfile branch from 54216d4 to d2e79f2 Compare September 18, 2023 09:57
@lihongyan1 lihongyan1 changed the title ci: bundle dockerfile is needed for presubmit prow job ci: bundle dockerfile is needed for prow job Sep 18, 2023
@jan--f
Copy link
Collaborator

jan--f commented Sep 21, 2023

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, lihongyan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 184884d into rhobs:main Sep 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants