fix: add description field to CSV base #366
Conversation
Signed-off-by: Mario Fernandez <[email protected]>
marioferh
requested review from
sthaha and
slashpai
and removed request for
a team
| @@ -59,40 +59,68 @@ spec: | |||
| apiservicedefinitions: {} | |||
| customresourcedefinitions: | |||
| owned: | |||
| - kind: AlertmanagerConfig | |||
| - description: AlertmanagerConfig defines a namespaced AlertmanagerConfig to be | |||
There was a problem hiding this comment.
Did you take a look at the UI rendering? I think it should be shorter to fit into the box, like in Gabriel's example
There was a problem hiding this comment.
It is ok, thanks!
There was a problem hiding this comment.
You can use https://operatorhub.io/preview to preview the bundle/csv.yaml
I think we can improve the AlertmanagerConfig a bit .. (ask chatgpt :D )
There was a problem hiding this comment.
BTW, are we now supporting all these API?
There was a problem hiding this comment.
In a cluster this is the result:
There was a problem hiding this comment.
"AlertmanagerConfig is used to define configurations for Prometheus Alertmanager, specifying how alerts are handled and routed for notifications."
Something like this?
There was a problem hiding this comment.
@simonpasquier would be the best judge of this :) .. BTW, for the record, this was only a suggestion and shouldn't block the PR from merging.
There was a problem hiding this comment.
small suggestion compared to @marioferh
... specifying how alerts are grouped and notified to external systems.
There was a problem hiding this comment.
|
The descriptions are not truncated and the boxes don't look text-heavy. /lgtm |
marioferh
force-pushed
the
add_descrpition_field_to_CSV
branch
from
1506632 to
df31425
Compare
Signed-off-by: Mario Fernandez <[email protected]>
marioferh
force-pushed
the
add_descrpition_field_to_CSV
branch
from
df31425 to
447fa95
Compare
|
/lgtm |
Signed-off-by: Mario Fernandez <[email protected]>
|
Thanks! I guess there is nothing but keeping these up-to-date manually is there? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, marioferh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add description field to CSV base of every owned CRD to generate correct description when run bundle generate.