Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump Prometheus operator to v0.68.0 #371

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat: bump Prometheus operator to v0.68.0 #371

merged 1 commit into from
Oct 18, 2023

Conversation

simonpasquier
Copy link
Contributor

No description provided.

@simonpasquier simonpasquier requested a review from a team as a code owner October 12, 2023 13:33
@simonpasquier simonpasquier requested review from slashpai and JoaoBraveCoding and removed request for a team October 12, 2023 13:33
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier simonpasquier requested a review from jan--f October 12, 2023 13:39
@simonpasquier
Copy link
Contributor Author

/retest

@jan--f
Copy link
Collaborator

jan--f commented Oct 13, 2023

I think we want s/v0.68.0-rhobs1/v0.68.0-rhobs2/ everywhere?

@danielmellado
Copy link
Contributor

probably, as we skipped rhobs1 as per the merge commit and the automation

@danielmellado
Copy link
Contributor

/assign @sthaha

@simonpasquier
Copy link
Contributor Author

In fact I messed up with the rhobs-rel-0.68.0-rhobs2 branch and there's no v0.68.0-rhobs2 of the obo-prometheus-operator image (see https://quay.io/repository/rhobs/obo-prometheus-operator?tab=tags). There's only a v0.68.0-rhobs1 tag which is built from rhobs/obo-prometheus-operator@a15e510.

@jan--f
Copy link
Collaborator

jan--f commented Oct 18, 2023 •
edited
Loading

Alright, as long as the sha's line up :)
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 18, 2023
@openshift-ci openshift-ci bot merged commit 50b7889 into rhobs:main Oct 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slashpai slashpai Awaiting requested review from slashpai slashpai is a code owner automatically assigned from rhobs/observability-operator-maintainers

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding JoaoBraveCoding is a code owner automatically assigned from rhobs/observability-operator-maintainers

@danielmellado danielmellado Awaiting requested review from danielmellado

@lihongyan1 lihongyan1 Awaiting requested review from lihongyan1

@jan--f jan--f Awaiting requested review from jan--f

Assignees

@jan--f jan--f

@sthaha sthaha

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simonpasquier @jan--f @danielmellado @sthaha @openshift-merge-robot