Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COO-480: feat: enable HTTPS in OpenShift clusters #595

Merged
merged 1 commit into from
Oct 29, 2024
Merged

COO-480: feat: enable HTTPS in OpenShift clusters #595

merged 1 commit into from
Oct 29, 2024

Conversation

simonpasquier
Copy link
Contributor

No description provided.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@simonpasquier simonpasquier changed the title feat: enable HTTPS in OpenShift clusters COO-480: feat: enable HTTPS in OpenShift clusters Oct 17, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 17, 2024 •
edited by openshift-ci bot
Loading

@simonpasquier: This pull request references COO-480 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier simonpasquier marked this pull request as ready for review October 18, 2024 07:06
@simonpasquier simonpasquier requested a review from a team as a code owner October 18, 2024 07:06
@simonpasquier simonpasquier requested review from sthaha and JoaoBraveCoding and removed request for a team October 18, 2024 07:06
@openshift-ci openshift-ci bot requested review from jan--f and jgbernalp October 18, 2024 07:06
@simonpasquier simonpasquier force-pushed the COO-480 branch 4 times, most recently from 7dd529c to 2877b9e Compare October 18, 2024 13:08
@simonpasquier
Copy link
Contributor Author

/test observability-operator-e2e
/test images

@simonpasquier
Copy link
Contributor Author

/test ci-index-observability-bundle

@simonpasquier simonpasquier force-pushed the COO-480 branch 9 times, most recently from fe1f665 to c65a5c1 Compare October 21, 2024 14:24
@simonpasquier simonpasquier force-pushed the COO-480 branch 3 times, most recently from ae46242 to 49173a8 Compare October 22, 2024 06:41
jan--f
jan--f approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very nice implementation and nice cleanups on the way ❤️

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

/test observability-operator-e2e

@simonpasquier
Copy link
Contributor Author

/hold
the e2e tests failed on the new TestOperatorMetrics test.

@openshift-ci openshift-ci bot removed the lgtm label Oct 25, 2024
@simonpasquier simonpasquier force-pushed the COO-480 branch 6 times, most recently from 5d65966 to ea4b6d1 Compare October 29, 2024 11:40
@simonpasquier
Copy link
Contributor Author

/hold cancel

@simonpasquier
feat: enable HTTPS in OpenShift clusters
ae9d9a5 
This change adds an end-to-end test ensuring that the operator's
/metrics endpoint works as expected.

When the OpenShift flag isn't enabled, metrics are still served over
HTTP.

Signed-off-by: Simon Pasquier <[email protected]>
@jan--f
Copy link
Collaborator

jan--f commented Oct 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a826c09 into rhobs:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f approved these changes

@sthaha sthaha Awaiting requested review from sthaha sthaha is a code owner automatically assigned from rhobs/observability-operator-maintainers

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding JoaoBraveCoding is a code owner automatically assigned from rhobs/observability-operator-maintainers

@jgbernalp jgbernalp Awaiting requested review from jgbernalp

Assignees

@jan--f jan--f

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonpasquier @openshift-ci-robot @jan--f