Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COO-318: add uiplugin support annotations when created #604

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

PeterYurkovich
Copy link
Contributor

@PeterYurkovich PeterYurkovich commented Oct 23, 2024

This PR looks to address COO-318 by adding support level annotations to the UIPlugins based on their type after they are created.

This adds an extra couple of reconciliations for each plugin, but doesn't trigger a reconciliation loop and is able to stabilize.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 23, 2024

@PeterYurkovich: This pull request references COO-318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR looks to address COO-318 by adding support level annotations to the UIPlugins based on their type after they are created.

This PR is rebased on top of #575 as both make changes in the compatibility matrix file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Oct 23, 2024

Hi @PeterYurkovich. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 23, 2024

@PeterYurkovich: This pull request references COO-318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR looks to address COO-318 by adding support level annotations to the UIPlugins based on their type after they are created.

This PR is rebased on top of #575 as both make changes in the compatibility matrix file. Changes can be found in the second commit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 23, 2024

@PeterYurkovich: This pull request references COO-318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR looks to address COO-318 by adding support level annotations to the UIPlugins based on their type after they are created.

This PR is rebased on top of #575 as both make changes in the compatibility matrix file. Changes can be found in the second commit.

This adds an extra couple of reconciliations for each plugin, but doesn't trigger a reconciliation loop and is able to stabilize.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich PeterYurkovich changed the title COO-318: add monitoring-plugin uiplugin COO-318: add uiplugin support annotations when created Oct 23, 2024
@PeterYurkovich PeterYurkovich marked this pull request as ready for review October 25, 2024 15:21
@PeterYurkovich PeterYurkovich requested a review from a team as a code owner October 25, 2024 15:21
@PeterYurkovich PeterYurkovich requested review from simonpasquier and sthaha and removed request for a team October 25, 2024 15:21
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 25, 2024

@PeterYurkovich: This pull request references COO-318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR looks to address COO-318 by adding support level annotations to the UIPlugins based on their type after they are created.

This adds an extra couple of reconciliations for each plugin, but doesn't trigger a reconciliation loop and is able to stabilize.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Oct 25, 2024

@PeterYurkovich: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jan--f
Copy link
Collaborator

jan--f commented Oct 28, 2024

Sorry I only saw this now after I pushed #607 😅

@jan--f
Copy link
Collaborator

jan--f commented Oct 28, 2024

This looks good to me, but happy to leave the final 👍 to @jgbernalp.

@jan--f
Copy link
Collaborator

jan--f commented Oct 29, 2024

@PeterYurkovich can you rebase on main please?

@PeterYurkovich
Copy link
Contributor Author

I'm out of office this week.

@jgbernalp and @zhuje you should have permission on my fork, mind doing the rebase?

@zhuje
Copy link
Contributor

zhuje commented Oct 29, 2024

@PeterYurkovich @jgbernalp, just pushed the rebase

@jan--f
Copy link
Collaborator

jan--f commented Oct 29, 2024

/lgtm

@jan--f
Copy link
Collaborator

jan--f commented Oct 29, 2024

/approve

Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 41c578c into rhobs:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants