Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add suggested namespace to bundle #630

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: add suggested namespace to bundle #630

merged 1 commit into from
Nov 20, 2024

Conversation

jan--f
Copy link
Collaborator

@jan--f jan--f commented Nov 20, 2024 •
edited by openshift-ci bot
Loading

Fixes: COO-32

@jan--f jan--f requested a review from a team as a code owner November 20, 2024 09:16
@jan--f jan--f requested review from sthaha and PeterYurkovich and removed request for a team November 20, 2024 09:16
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marioferh
marioferh reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 20, 2024
@simonpasquier
Copy link
Contributor

/lgtm

will we customize this downstream with an openshift- prefix?

@simonpasquier
Copy link
Contributor

replying to myself, we need the openshift- prefix to display the "enable cluster monitoring" checkbox during install.

@jan--f
Copy link
Collaborator Author

jan--f commented Nov 20, 2024

replying to myself, we need the openshift- prefix to display the "enable cluster monitoring" checkbox during install.

ahh yes good point. I added the downstream customization to cluster-observability-operator but forgot about the telemetry bits. rhobs/konflux-coo#171

@jan--f
Copy link
Collaborator Author

jan--f commented Nov 20, 2024

fixed in rhobs/konflux-coo#186

@openshift-merge-bot openshift-merge-bot bot merged commit 420ad91 into rhobs:main Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh marioferh left review comments

@sthaha sthaha Awaiting requested review from sthaha sthaha is a code owner automatically assigned from rhobs/observability-operator-maintainers

@PeterYurkovich PeterYurkovich Awaiting requested review from PeterYurkovich PeterYurkovich is a code owner automatically assigned from rhobs/observability-operator-maintainers

@periklis periklis Awaiting requested review from periklis

Assignees

@simonpasquier simonpasquier

@marioferh marioferh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jan--f @simonpasquier @marioferh