Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_sandbox.py: Add a test to ensure Vault value is correct #111

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

fridim
Copy link
Contributor

@fridim fridim commented Feb 5, 2025

Try to read one key with the passed vault secret. If it doesn't work, exit. That will prevent accidentally creating sandboxes with a vault different that the one currently in use for the 'target DB'

@fridim fridim changed the title Add a test to ensure Vault value is correct create_sandbox.py: Add a test to ensure Vault value is correct Feb 5, 2025
Copy link

@ashokjammula1 ashokjammula1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Try to read one key with the passed vault secret. If it doesn't work, exit. That will prevent accidentally creating sandboxes with a vault different that the one currently in use for the 'target DB'
@ashokjammula1 ashokjammula1 merged commit 6328250 into main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants