Allowing boolean array in delayed_subsample #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhugonnet
approved these changes
May 21, 2024
There was a problem hiding this comment.
Perfect! We'd just have to mention the behaviour for boolean arrays in the function description, and add a test that checks it returns exactly the same subsample for a boolean array matching a NaN array, then we can merge GlacioHack#537!
|
Thanks for the feedback @rhugonnet! I've updated the tests and updated the docstrings to reflect the changes. Let me know if anything is missing otherwise feel free to merge 👍 😃 |
rhugonnet
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability of subsampling from boolean array inputs in
delayed_subsample.api/*.mdfor new API.