Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding extension to import statements #242

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

DCsunset
Copy link
Collaborator

This PR adds a new option to add custom extension for import statements in generated guards.

This feature is necessary for generated files to work in ESM as .js extension is required in import statements.

This PR should close #227.

@rhys-vdw
Copy link
Owner

Very nice, thank you for your contribution. I'm inviting you on as a collaborator should you be interested.

@rhys-vdw rhys-vdw merged commit 4f8ba08 into rhys-vdw:master Feb 25, 2024
2 checks passed
@DCsunset
Copy link
Collaborator Author

Great! I've accepted the invitation and may try to help with some issues when I have time.

@rhys-vdw
Copy link
Owner

Cool! No pressure to act, I just like to add everyone who contributes because I'm not using this project anymore. Pls just open issues to discuss before making any major changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for explicit file extensions when using ESM
2 participants