Add MTS and CTS Support #244
Conversation
Add support for MTS and CTS files if detected, otherwise fall back to standard TS output. Add comments and JS Docs to refactored function. Add return type to make function typing explicit. Switch to Unicode regex to support multi-language filesystems and emoji (when FSs eventually all get UTF8 support).
Add support to the --import-guards functionality to make sure that it is feature paired with the new code for the file outputting logic.
|
Hi @elliot-huffman, this looks good to me. Could you deduplicate the regex used for the file extensions? Declare it as a constant regex. Slight oversight, you've made one case insensitive but not the other. DRYing this would help such mistakes in future. Also you'll need to prettier format for the tests to pass. You can Once this is merged I'll add you on as a collaborator if you would like it, so let me know. Thank you for your contribution! |
Migrate to string primitive methods to reduce risk of breach and improve performance.
I would love that! As a precaution, I have replaced the regex with more preformat and less risk of regex compromise, string primitive methods. |
@elliot-huffman Sorry, I should have been more specific! I've added line comments. You didn't add the regexes, but you've caused them to deviate. I would prefer to see: // somewhere near top of file
const fileExtensionRegex = /\.(ts|mts|cts|tsx|d\.ts)$/uTo ensure that they keep in sync in future.
Inviting you now. |
Remove the duplicate code that the file matcher logic uses and have it at the top of the entry file instead of declared inline. Make sure that all regular expressions are Unicode compatible and that they are case insensitive matches. This behavior that should be caught on the Windows platform, as Windows is case insensitive and this could cause a namespace collision if not insensitive matching. While possible to have two different files with the same name only differing on linux and MacOS, this is generally agreed upon as a bad practice.
|
Nice one. |
This PR adds
MTSandCTSsupport for file output and input so that projects that use mixed module modes are supported.Currently when an MTS or CTS file is used, the following error is encountered:
Internal Error: sourcePath and outFilePath are identical: ...