Skip to content

Commit

Permalink
Remove unused maxCommits getter (flutter#3633)
Browse files Browse the repository at this point in the history
Pull request removes an unused getter but is meant to test buildbucket v2 through postsubmit.

Wait to merge.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
  • Loading branch information
ricardoamador authored Apr 10, 2024
1 parent 654c82c commit 9dd49cd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions app_dart/lib/src/service/config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,6 @@ class Config {
'[email protected]',
};

int get maxTaskRetries => 2;

/// Max retries for Luci builder with infra failure.
int get maxLuciTaskRetries => 2;

Expand Down
3 changes: 0 additions & 3 deletions app_dart/test/src/datastore/fake_config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,6 @@ class FakeConfig implements Config {
@override
Duration get githubRequestDelay => githubRequestDelayValue ?? Duration.zero;

@override
int get maxTaskRetries => maxTaskRetriesValue!;

/// Size of the shards to send to buildBucket when scheduling builds.
@override
int get schedulingShardSize => 5;
Expand Down

0 comments on commit 9dd49cd

Please sign in to comment.