Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to vanilla Javacript, without jQuery or other dependencies #22

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

onli
Copy link

@onli onli commented Sep 20, 2023

This takes the code from the develop branches and moves it to modern JS: Regular modules, no jQuery, no url require module. To create a shariff.complete.js (for the demopage) I used rollup.js, like this:

rollup src/js/main.js -o demo/shariff.complete.js

It's likely there are alternatives. The javscript files with the modern modules also work directly in the browser, if you embed the main.js.

The facebooklike functionality is kept, but wasn't testable for me. I did not understand the purpose of the facebooklike_dlg.js with a reference to .less file (?), so I could not re-add it when restoring the dialog functionality. You might have to fix some aspects there.

In general, the whole code was only tested in the browser, without compiling the CSS.

The CSS side of the project wasn't touched. This PR does not contain the changes to the package.json or other documentation files.

@richard67
Copy link
Owner

Thanks. Will check on weekend.

@onli
Copy link
Author

onli commented Sep 20, 2023

Cat pressed the enter button, I edited in a description now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants