Port to vanilla Javacript, without jQuery or other dependencies #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the code from the develop branches and moves it to modern JS: Regular modules, no jQuery, no url require module. To create a shariff.complete.js (for the demopage) I used rollup.js, like this:
It's likely there are alternatives. The javscript files with the modern modules also work directly in the browser, if you embed the
main.js
.The facebooklike functionality is kept, but wasn't testable for me. I did not understand the purpose of the facebooklike_dlg.js with a reference to .less file (?), so I could not re-add it when restoring the dialog functionality. You might have to fix some aspects there.
In general, the whole code was only tested in the browser, without compiling the CSS.
The CSS side of the project wasn't touched. This PR does not contain the changes to the package.json or other documentation files.