Add QskArcShadowNode #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-vogel
commented
Dec 5, 2023
src/nodes/QskArcNode.cpp
Outdated
|
|
||
| namespace | ||
| { | ||
| struct QskArcShadowMaterialProperties |
There was a problem hiding this comment.
- complete documentation of valua ranges
rick-vogel
commented
Dec 5, 2023
src/nodes/QskArcNode.cpp
Outdated
| qreal extend = 16.0; //< pixel >= 0.0 | ||
| }; | ||
|
|
||
| class QskArcShadowMaterial final : public QSGSimpleMaterialShader<QskArcShadowMaterialProperties> |
There was a problem hiding this comment.
- use QSG classes and prepare for Qt6 RHI
rick-vogel
commented
Dec 5, 2023
src/nodes/QskArcNode.cpp
Outdated
| auto& state = *material->state(); | ||
| state.color = color; | ||
| state.rect = r; | ||
| state.radius = 1.0 - (metrics.thickness() + extend / 4) / size; |
rick-vogel
commented
Dec 5, 2023
src/nodes/QskArcNode.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| const auto path = metrics.painterPath( arcRect ); | ||
|
|
||
| if ( true /* TODO */ ) |
There was a problem hiding this comment.
- TODO add shadow node condition
rick-vogel
commented
Dec 5, 2023
src/nodes/QskArcNode.cpp
Outdated
| QskSGNode::setNodeRole( shadowNode, ShadowRole ); | ||
| } | ||
|
|
||
| const auto extend = 16.0; |
rick-vogel
commented
Dec 9, 2023
src/nodes/QskArcNode.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| const auto path = metrics.painterPath( arcRect ); | ||
|
|
||
| if ( shadowColor.alpha() > 0.0 ) |
There was a problem hiding this comment.
@uwerat One could argue that if the gradient and stroke aren't visible the shadow is also not visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream: uwerat#350