Ability to set database, fix for multi-line queries and example.sh #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 25, 2014 17:21
Default DB is "default". The USE <datbase> is executed prior to every query, which might not be optimal, but it works.
Don't replace newlines with empty string - this would cause multi-line queries to fail syntax check if there wasn't whitespace @ EOL or before next line Also, this allows multi-line queries with comments in them to run successfully. Example: SELECT count(*) -- this is a comment FROM customers;
|
I agree with the premise of having a default database, but I don't think doubling RPC calls is a good idea when we're trying to benchmark performance. We could see if re-using the cursor is possible, that way you only have to execute the "USE" command at the beginning of the thread startup. I seem to remember that I was doing that before, and it was causing issues with with long running cursors. The other option is to parse each query for the table name, and inject the database dot notation in front of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/NathanNeff