Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup & test fix #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

cleanup & test fix #14

wants to merge 4 commits into from

Conversation

ThunderEX
Copy link

This PR include:

  1. remove dependency on copy module which is unnecessary, that also allow pyaes run on micropython.
  2. fix imports. for tests, correct path of import, use recommended absolute import to replace relative import, rename StringIO to BytesIO to fit real variable type.
  3. remove ugly workaround for py2/3, replace with bytes/bytearray.
  4. don't mask MSB, increase speed a little bit

@ricmoo
Copy link
Owner

ricmoo commented May 4, 2017

Awesome work! Thank you.

I haven't dealt much with Python 3, but will research these changes next week and verify the test cases, and if all is good merge. :)

@ThunderEX
Copy link
Author

@ricmoo I mistakenly break down python2 in last commit and now fix it up. pls have a look~

@ricmoo
Copy link
Owner

ricmoo commented May 17, 2017

Thanks! I'll look at this next week, as this week is pretty busy. I have a lot of house cleaning to catch up on for my various GitHub projects...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants