Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

\Config 의존성 제거 #26

Open
kiding opened this issue Nov 20, 2019 · 1 comment · Fixed by #31 or #32
Open

\Config 의존성 제거 #26

kiding opened this issue Nov 20, 2019 · 1 comment · Fixed by #31 or #32

Comments

@kiding
Copy link

kiding commented Nov 20, 2019

$connection = DriverManager::getConnection(\Config::getConnectionParams($group_name), $config);

$helper = new MailgunHelper(\Config::$MAILGUN_API_KEY);

if (\Config::$UNDER_DEV) {

if (empty(\Config::$DEV_MAIL_RECEIVER)) {

/**
* 환경변수 의존성 존재함
* \Config::$MAILGUN_API_KEY
* \Config::$MAILGUN_SEND_DOMAIN
* \Config::$MAILGUN_PUBLIC_ID
* \Config::$MAILGUN_PUBLIC_KEY
* \Config::$MAILGUN_EMAIL_VALIDATE_API_URL
* \Config::$MAILGUN_SECRET_KEY_OPT_OUT
*/

if (\Config::$UNDER_DEV) {

Global namespace \Config 클래스에 의존적인 코드가 일부 남아있습니다. config.php 대신 .env로 변경하는 추세 1 2 3 4 에 맞춰 의존성을 제거할 필요가 있습니다.

@ssaifriend ssaifriend self-assigned this Apr 24, 2020
This was linked to pull requests Apr 27, 2020
@ssaifriend
Copy link
Contributor

GnfConnectionProvider 의 경우 잘못된 class (PDO) 를 사용하고 있고,
참조 제거를 위해 고민이 필요한 점을 미리 남겨둡니다.

@ssaifriend ssaifriend reopened this May 7, 2020
@ssaifriend ssaifriend reopened this May 7, 2020
@ssaifriend ssaifriend removed their assignment Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants