Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

Remove Config reference in PingService #32

Merged
merged 3 commits into from
May 7, 2020

Conversation

ssaifriend
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #32 into master will increase coverage by 1.23%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     15.17%   16.41%   +1.23%     
- Complexity      843      845       +2     
============================================
  Files            84       84              
  Lines          2477     2480       +3     
============================================
+ Hits            376      407      +31     
+ Misses         2101     2073      -28     
Impacted Files Coverage Δ Complexity Δ
lib/PingService/HealthCheckUtils.php 0.00% <0.00%> (ø) 1.00 <1.00> (ø)
lib/PingService/PushMonUtils.php 0.00% <0.00%> (ø) 1.00 <1.00> (ø)
lib/PingService/AbstractPingUtils.php 81.57% <90.00%> (+81.57%) 12.00 <12.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c472396...851a5a9. Read the comment docs.

@ssaifriend ssaifriend linked an issue Apr 27, 2020 that may be closed by this pull request
@kiding kiding self-requested a review April 28, 2020 01:23
tests/Helper/PingTest.php Outdated Show resolved Hide resolved
@ssaifriend ssaifriend merged commit f2f247a into master May 7, 2020
@ssaifriend ssaifriend deleted the improve/remove_config_in_ping_utils branch May 7, 2020 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\Config 의존성 제거
2 participants