Refactoring of GridViewDataSet #2692
Annotations
3 errors and 1 warning
|
src/Tests/Runtime/ConfigurationSerializationTests.cs#L69
Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception:
System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
index 31d5da1..042ab80 100644
--- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
+++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
@@ -526,6 +526,10 @@
"mappingMode": "InnerElement",
"onlyHardcoded": true
},
+ "LoadData": {
+ "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework",
+ "onlyBindings": true
+ },
"NextPageTemplate": {
"type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework",
"mappingMode": "InnerElement",
@@ -1641,23 +1645,6 @@
"isActive": true,
"isAttached": true
}
- },
- "DotvvmMarkupControl-33jwRoNrnlbAOVpOnCErXw==": {
- "ShowDescription": {
- "type": "System.Boolean",
- "defaultValue": false
- }
- },
- "DotvvmMarkupControl-koCHqjx2oIk1rVwG1PzLJQ==": {
- "Click": {
- "type": "DotVVM.Framework.Binding.Expressions.Command, DotVVM.Framework",
- "isCommand": true
- }
- },
- "DotvvmMarkupControl-YYPITyOzVEL518wclEMJZw==": {
- "SomeProperty": {
- "type": "System.String"
- }
}
},
"capabilities": {
If this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
src/Tests/ControlTests/DataPagerTests.cs#L43
Test method DotVVM.Framework.Tests.ControlTests.DataPagerTests.CommandDataPager threw exception:
System.Exception: DataPagerTests.CommandDataPager.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html
index 865a938..bb4fd40 100644
--- a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html
+++ b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html
@@ -1,26 +1,26 @@
<html>
<head></head>
<body>
- <ul data-bind="dotvvm-gridviewdataset: { dataSet: Customers() }, visible: (Customers()).PagingOptions().PagesCount() > 1, with: Customers">
+ <ul data-bind="dotvvm-gridviewdataset: { dataSet: Customers() }, visible: (Customers()).PagingOptions().PagesCount() > 1">
<li data-bind="css: { 'disabled': $gridViewDataSetHelper.dataSet.PagingOptions().IsFirstPage() }">
- <a href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers"],"YNrHJz3wB1224tUc","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">««</a>
+ <a href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers"],"kGlDaLNXj8NK2V17","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">««</a>
</li>
<li data-bind="css: { 'disabled': $gridViewDataSetHelper.dataSet.PagingOptions().IsFirstPage() }">
- <a href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers"],"YNrHJz3wB1224tUc","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">«</a>
+ <a href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers"],"d14Ckwn2LsbnFaGZ","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">«</a>
</li>
<!-- ko foreach: $gridViewDataSetHelper.dataSet.PagingOptions().NearPageIndexes -->
- <li class="active" data-bind="visible: $data == $parent.PagingOptions().PageIndex()">
+ <li class="active" data-bind="visible: $data == $parentContext.$gridViewDataSetHelper.dataSet.PagingOptions().PageIndex()">
<span data-bind="text: 1+$data+"""></span>
</li>
- <li data-bind="visible: $data != $parent.PagingOptions().PageIndex()">
- <a data-bind="text: 1+$data+""" href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers","PagingOptions.NearPageIndexes[$index]"],"ZwmBknlLAz5Evw5W","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;"></a>
+ <li data-bind="visible: $data != $parentContext.$gridViewDataSetHelper.dataSet.PagingOptions().PageIndex()">
+ <a data-bind="text: 1+$data+""" href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers","$parent.PagingOptions.NearPageIndexes[$index]"],"kr+sAzElmt30FupZ","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;"></a>
</li>
<!-- /ko -->
- <li data-bind="css: { 'disabled': PagingOptions().IsLastPage() }">
- <a href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers"],"YNrHJz3wB1224tUc","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">»</a>
+ <li data-bind="css: { 'disabled': $gridViewDataSetHelper.dataSet.PagingOptions().IsLastPage() }">
+ <a href="javascript:;" onclick="dotvvm.postBack(this,["$parent.Customers"],"F3UcKoU2hPi8n7wT","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">»</a>
</li>
- <li data-bind="css: { 'disabled': PagingOptions().IsLastPage() }">
- <a href="javascript:;"
|
|
|
|
|
The logs for this run have expired and are no longer available.
Loading