Refactoring of GridViewDataSet #2762
Annotations
10 errors
|
src/Tests/Runtime/ConfigurationSerializationTests.cs#L69
Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception:
System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
index 042ab80..9e21b08 100644
--- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
+++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
@@ -375,6 +375,10 @@
"type": "DotVVM.Framework.Binding.Expressions.Command, DotVVM.Framework",
"isCommand": true
},
+ "ClickArguments": {
+ "type": "System.Collections.Generic.List`1[[System.Object, CoreLibrary]]",
+ "mappingMode": "Exclude"
+ },
"Enabled": {
"type": "System.Boolean",
"defaultValue": true
@@ -731,6 +735,10 @@
"defaultValue": false,
"onlyHardcoded": true
},
+ "LoadData": {
+ "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework",
+ "onlyBindings": true
+ },
"RowDecorators": {
"type": "System.Collections.Generic.List`1[[DotVVM.Framework.Controls.Decorator, DotVVM.Framework, Version=***, Culture=neutral, PublicKeyToken=23f3607db32275da]]",
"dataContextChange": [
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
src/Tests/ControlTests/AutoUITests.cs#L96
Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicColumn threw exception:
System.Exception: AutoUITests.BasicColumn.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html
index 287823d..b418550 100644
--- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html
+++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html
@@ -3,7 +3,7 @@
<body>
<!-- ko if: List()?.Items()?.length -->
- <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}">
+ <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }">
<thead>
<tr>
<th class="">
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
src/Tests/ControlTests/AutoUITests.cs#L131
Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicGrid threw exception:
System.Exception: AutoUITests.BasicGrid.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html
index ab33b4c..117a6f0 100644
--- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html
+++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html
@@ -3,7 +3,7 @@
<body>
<!-- ko if: List()?.Items()?.length -->
- <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}">
+ <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }">
<thead>
<tr>
<th class="">
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
src/Tests/ControlTests/CompositeControlTests.cs#L71
Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.WrappedRepeaterControl threw exception:
System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.
|
|
src/Tests/ControlTests/CompositeControlTests.cs#L140
Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.CommandDataContextChange threw exception:
DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.
|
|
src/Tests/ControlTests/CompositeControlTests.cs#L160
Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.AutoclonedPostbackHandlers threw exception:
DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.
|
|
src/Tests/ControlTests/DataPagerTests.cs#L43
Test method DotVVM.Framework.Tests.ControlTests.DataPagerTests.CommandDataPager threw exception:
System.Exception: DataPagerTests.CommandDataPager.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html
index 7f541e0..0b6f4a1 100644
--- a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html
+++ b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html
@@ -1,7 +1,7 @@
<html>
<head></head>
<body>
- <ul data-bind="dotvvm-gridviewdataset: { dataSet: Customers() }, visible: (Customers()).PagingOptions().PagesCount() > 1">
+ <ul data-bind="visible: Customers()?.PagingOptions()?.PagesCount() > 1">
<li class="disabled" data-bind="css: { disabled: Customers()?.PagingOptions()?.IsFirstPage }">
<a href="javascript:;" onclick="dotvvm.postBack(this,[],"XV5Ciz2t6C9bIsEQ","",null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">««</a>
</li>
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
src/Tests/ControlTests/GridViewTests.cs#L120
Test method DotVVM.Framework.Tests.ControlTests.GridViewTests.RequiredResourceInEditTemplate threw exception:
System.Exception: GridViewTests.RequiredResourceInEditTemplate.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html
index 0e56043..d164cdd 100644
--- a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html
+++ b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html
@@ -3,7 +3,7 @@
<body>
<!-- ko if: EmptyCustomers()?.Items()?.length -->
- <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':EmptyCustomers()}">
+ <table data-bind="dotvvm-gridviewdataset: { dataSet: EmptyCustomers(), mapping: {} }">
<thead>
<tr>
<th>
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
src/Tests/ControlTests/ServerSideStyleTests.cs#L332
Test method DotVVM.Framework.Tests.ControlTests.ServerSideStyleTests.BindableObjectReads threw exception:
System.Exception: ServerSideStyleTests.BindableObjectReads.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html
index 383b9dd..e1b1422 100644
--- a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html
+++ b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html
@@ -4,7 +4,7 @@
<!-- no header attribute -->
<!-- ko if: Collection()?.length -->
- <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}">
+ <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }">
<thead>
<tr>
<th>
@@ -23,7 +23,7 @@
<!-- /ko -->
<!-- has header attribute -->
<!-- ko if: Collection()?.length -->
- <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}" data-headers="RealValue ; Test">
+ <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }" data-headers="RealValue ; Test">
<thead>
<tr>
<th>
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
|
The logs for this run have expired and are no longer available.
Loading