New dot:ModalDialog control, wrapper for <dialog> #2897
Annotations
3 errors and 6 warnings
|
Tests (net8.0):
src/Tests/Runtime/ConfigurationSerializationTests.cs#L69
Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception:
System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
index c595e0f..6058b5d 100644
--- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
+++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
@@ -1175,6 +1175,21 @@
"defaultValue": ""
}
},
+ "DotVVM.Framework.Controls.ModalDialog": {
+ "Close": {
+ "type": "DotVVM.Framework.Binding.Expressions.Command, DotVVM.Framework",
+ "isCommand": true
+ },
+ "CloseOnBackdropClick": {
+ "type": "System.Boolean",
+ "defaultValue": false
+ },
+ "Open": {
+ "type": "System.Object",
+ "defaultValue": false,
+ "onlyBindings": true
+ }
+ },
"DotVVM.Framework.Controls.MultiSelector": {
"SelectedValues": {
"type": "System.Object",
@@ -2214,6 +2229,10 @@
"baseType": "DotVVM.Framework.Controls.HtmlGenericControl, DotVVM.Framework",
"withoutContent": true
},
+ "DotVVM.Framework.Controls.ModalDialog": {
+ "assembly": "DotVVM.Framework",
+ "baseType": "DotVVM.Framework.Controls.HtmlGenericControl, DotVVM.Framework"
+ },
"DotVVM.Framework.Controls.MultiSelect": {
"assembly": "DotVVM.Framework",
"baseType": "DotVVM.Framework.Controls.MultiSelectHtmlControlBase, DotVVM.Framework"
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
|
Tests (net8.0):
src/Tests/Runtime/DotvvmPropertyTests.cs#L306
Test method DotVVM.Framework.Tests.Runtime.DotvvmPropertyTests.DotvvmProperty_CorrectGetAndSet threw exception:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.InvalidCastException: Unable to cast object of type 'System.String' to type 'System.Nullable`1[System.Boolean]'.
|
|
Tests (net8.0)
Process completed with exit code 1.
|
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, nuget/setup-nuget@v1, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The logs for this run have expired and are no longer available.
Loading