Removed unnecessary data-bind and added check for hard-coded values

riganti · Jan 18, 2023 · 0ee2368 · 0ee2368
1 parent fb19050
commit 0ee2368
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/Framework/Framework/Controls/Validator.cs b/src/Framework/Framework/Controls/Validator.cs
@@ -99,9 +99,15 @@ private static void AddValidatedValue(IHtmlWriter writer, IDotvvmRequestContext
             }
             else
             {
-                // Could not resolve ValueProperty to a valid value binding
-                // Note: this can sometimes happen when using AutomaticValidation in BusinessPack
-                writer.AddKnockoutDataBind(validationDataBindName, control, ValueProperty, renderEvenInServerRenderingMode: true);
+                // Note: ValueProperty can sometimes contain null (BusinessPack depends on this behaviour)
+                // However, it certainly should not contain hard-coded values
+
+                var valueRaw = control.GetValueRaw(ValueProperty);
+                if (valueRaw != null)
+                {
+                    // There is a hard-coded value in the ValueProperty
+                    throw new DotvvmControlException($"{nameof(ValueProperty)} can not contain a hard-coded value.");
+                }
             }
 
             // render options