CompilationPage: add title to truncated table columns

riganti · Oct 17, 2023 · d231809 · d231809
1 parent 06f82c4
commit d231809
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/src/Framework/Framework/Diagnostics/CompilationPage.dothtml b/src/Framework/Framework/Diagnostics/CompilationPage.dothtml
@@ -1,4 +1,4 @@
-@viewModel DotVVM.Framework.Diagnostics.CompilationPageViewModel
+@viewModel DotVVM.Framework.Diagnostics.CompilationPageViewModel
 
 <!DOCTYPE html>
 <html lang="en">
@@ -52,15 +52,19 @@
                     <dot:GridViewTemplateColumn HeaderText="Url">
                         <ContentTemplate>
                             <span IncludeInPage={value: !HasParameters}>
-                                <a href="{value: "/" +  Url}">{{value: Url}}</a>
+                                <a href="{value: _root.PathBase + Url}">{{value: Url == "" ? "<Empty>" : Url}}</a>
                             </span>
-                            <span IncludeInPage={value: HasParameters}>
+                            <span IncludeInPage={value: HasParameters} title={value: Url}>
                                 {{value: Url}}
                             </span>
                         </ContentTemplate>
                     </dot:GridViewTemplateColumn>
                     <dot:GridViewTextColumn ValueBinding="{value: VirtualPath}"
-                                            HeaderText="Virtual Path" />
+                                            HeaderText="Virtual Path">
+                        <CellDecorators>
+                            <dot:Decorator title={value: VirtualPath} />
+                        </CellDecorators>
+                    </dot:GridViewTextColumn>
                     <dot:GridViewTextColumn ValueBinding="{value: Status}"
                                             HeaderText="Status"
                                             HeaderCssClass="fit"
@@ -89,7 +93,11 @@
                                             HeaderCssClass="fit"
                                             CssClass="fit" />
                     <dot:GridViewTextColumn ValueBinding="{value: TagName}" HeaderText="Tag" />
-                    <dot:GridViewTextColumn ValueBinding="{value: VirtualPath}" HeaderText="Virtual Path" />
+                    <dot:GridViewTextColumn ValueBinding="{value: VirtualPath}" HeaderText="Virtual Path">
+                        <CellDecorators>
+                            <dot:Decorator title={value: VirtualPath} />
+                        </CellDecorators>
+                    </dot:GridViewTextColumn>
                     <dot:GridViewTextColumn ValueBinding="{value: Status}"
                                             HeaderText="Status"
                                             HeaderCssClass="fit"
@@ -112,11 +120,15 @@
                                    Class-success="{value: Status == 'CompletedSuccessfully'}" />
                 </RowDecorators>
                 <Columns>
-                    <dot:GridViewTextColumn ValueBinding="{value: VirtualPath}" HeaderText="Virtual Path" />
+                    <dot:GridViewTextColumn ValueBinding="{value: VirtualPath}" HeaderText="Virtual Path">
+                        <CellDecorators>
+                            <dot:Decorator title={value: VirtualPath} />
+                        </CellDecorators>
+                    </dot:GridViewTextColumn>
                     <dot:GridViewTextColumn ValueBinding="{value: Status}"
                                             HeaderText="Status"
                                             HeaderCssClass="fit"
-                                            CssClass="fit status" />
+                                            CssClass="fit status"/>
                     <dot:GridViewTemplateColumn HeaderText="Actions" HeaderCssClass="fit" CssClass="fit">
                         <ContentTemplate>
                             <span Visible="{value: Status != CompilationState.NonCompilable}">

diff --git a/src/Framework/Framework/Diagnostics/CompilationPageViewModel.cs b/src/Framework/Framework/Diagnostics/CompilationPageViewModel.cs
@@ -15,6 +15,7 @@ public class CompilationPageViewModel : DotvvmViewModelBase
         public ImmutableArray<DotHtmlFileInfo> MasterPages => viewCompilationService.GetMasterPages();
         public ImmutableArray<DotHtmlFileInfo> Controls => viewCompilationService.GetControls();
         public int ActiveTab { get; set; } = 0;
+        public string PathBase => Context.TranslateVirtualPath("~/");
 
         public CompilationPageViewModel(IDotvvmViewCompilationService viewCompilationService)
         {