Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with not attaching errors when propertyPaths could not be resolved #1500

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

acizmarik
Copy link
Member

This PR is cherry-picking important bugfix from #1498. Right now, when attaching errors on an non-existing object, the function throws. Therefore, we never trigger the validationErrorsChanged event. At the end even valid errors are not displayed.

Users can encounter this issue in the following ways:

  • Manually specifying incorrect property paths using our string notation
  • Providing correct expression or correct property path but the viewmodel changes (i.e. the property where we need to attach errors is no longer reachable from root viewmodel)

@acizmarik acizmarik added this to the Version 4.1 milestone Nov 2, 2022
@acizmarik acizmarik added the bug label Nov 2, 2022
@acizmarik acizmarik merged commit f4fc7e5 into main Nov 2, 2022
@acizmarik acizmarik deleted the fix/validation-not-attaching-errors branch November 2, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants