Refactoring of GridViewDataSet #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
feature/new-datasets
branch
from
18b3058 to
2ca439b
Compare
tomasherceg
force-pushed
the
feature/new-datasets
branch
from
ac3cf9a to
8dcf71f
Compare
exyi
force-pushed
the
feature/new-datasets
branch
from
52a010c to
65fe97f
Compare
tomasherceg
force-pushed
the
feature/new-datasets
branch
from
d57ecbb to
4c1f8c1
Compare
exyi
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Other significant unsolved problems are:
- The dataset translations will only work in the context of DataSetClientSideLoad, not in ad-hoc staticCommand
- Async LoadFromQueryable (and the IPagingOptionsLoadingPostProcessor interface), I will make a separate PR for that
| (dataSource as IPageableGridViewDataSet<IPagingFirstPageCapability>)?.PagingOptions.GoToFirstPage(); | ||
| (dataSource as IRefreshableGridViewDataSet)?.RequestRefresh(); | ||
| }), | ||
| new IdBindingProperty($"{this.GetDotvvmUniqueId().GetValue()}_sortBinding") |
There was a problem hiding this comment.
We used to simply call the SortChanged without the additional paging+refresh, why is this needed? Since we now have the Button CommandParameters, we wouldn't have to touch the SortChanged binding and we could thus simply allow staticCommands here.
who knows if it works...
Creates a nested data context with _index and _collection extension parameters
* introduced symbolic parameters for $gridViewDataSet.loadData function.
we need to substitute this loadData function on a single element, so
we cannot use dotvvm-gridviewdataset to change the data context.
* refactored PostbackOptions to a record to allow using `with { ... }` syntax
…ssion is multiline
…tor arguments are)
exyi
force-pushed
the
feature/new-datasets
branch
from
a2a79a6 to
4fbe3cb
Compare
- to make it possible to implement `aria-labels` classes on links, and reader only spans I implemented extensibility points
Data pager extensibility improvements
Normally, we return the inner mutable list, if it is IList. If it isn't we return a ReadOnlyCollection wrapper, to throw an exception instead of mutating the copy
DataPager now marks unavailable pages as `disabled`
tomasherceg
commented
Jun 7, 2024
| /// </summary> | ||
| int PageIndex { get; set; } | ||
| void GoToNextPage(); |
There was a problem hiding this comment.
I'd prefer keeping these names because people who built custom pager were probably using these methods.
* rename GridViewCommands -> GridViewBindings * add some doccomments * moved SortCriterion to MultiCriteriaSortingOptions file
tomasherceg
force-pushed
the
feature/new-datasets
branch
from
817bc7c to
6cab06d
Compare
exyi
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to make
GridViewDataSetextensible and loadable on the client side.