Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS test for nested postbacks #1709

Merged
merged 1 commit into from
Oct 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Framework/Framework/Resources/Scripts/tests/helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export async function waitForEnd<T>(result: Promise<T>[], s: fc_types.Scheduler,

while (!done) {
// console.log(s.report())
expect(s.count()).toBeGreaterThan(0)
expect(s.count()).toBeGreaterThan(0) // scheduler is stuck - in reality there would be deadlock
await s.waitOne()

assert()
Expand Down
92 changes: 92 additions & 0 deletions src/Framework/Framework/Resources/Scripts/tests/postback.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -420,3 +420,95 @@ test("Postback: AbortSignal", async () => {

expect(postbackPromise).rejects.toMatchObject( {reason: {type: "abort"}})
})

test("Run postbacks [Queue + Default | no failures]", async () => {
jest.setTimeout(120_000);

// watchEvents()

await fc.assert(fc.asyncProperty(
fc.integer(1, 10),
fc.boolean(),
fc.boolean(),
fc.constantFrom<{parent: [string, object]; nested: [string, object]}[]>(
{ parent: ["concurrency-queue", { q: "parent" }], nested: ["concurrency-queue", { q: "nested" }] },
{ parent: ["concurrency-queue", { q: "parent" }], nested: ["concurrency-deny", { q: "nested" }] }, // first queue should be enough to avoid races
{ parent: ["concurrency-queue", { q: "parent" }], nested: ["concurrency-default", { q: "nested" }] }, // first queue should be enough to avoid races
{ parent: ["concurrency-default", { q: "parent" }], nested: ["concurrency-default", { q: "nested" }] },
{ parent: ["concurrency-deny", { q: "parent" }], nested: ["concurrency-default", { q: "nested" }] },
),
fc.scheduler(),
async (parallelism, nestedBefore, nestedAfter, concurrency, scheduler) => {
// wait for stuff to settle down
// postbacks from the previous run may have been running or so
await delay(1)
resetQueues()

// console.debug("Starting new test ", parallelismQ, parallelismD)
let index = 0
let index2 = 0
fetchJson = async(url: string, init: RequestInit) => {
const { command } = JSON.parse(init.body as string)
if (command == "nested") {
return makeResponse({
Property1: ++index
})
} else if (command == "default") {
return makeResponse({
Property2: ++index2
})
}
}

getStateManager().update(x => ({...x, Property1: 0, Property2: 0}))

async function runNestedPostback(name: string) {
await postBack(window.document.body, [], "nested", "", undefined, [concurrency.nested, cancerPostbackHandler(scheduler, name) ]).catch(_ => {})
}

function postbackHandler(name: string): DotvvmPostbackHandler {
return {
name: "run-nested-postback",
async execute(next: () => Promise<PostbackCommitFunction>): Promise<PostbackCommitFunction> {
if (nestedBefore) {
await runNestedPostback(name + "-nested-before")
}
const commit = await next()
return async () => {
const result = await commit()
if (nestedAfter) {
await runNestedPostback(name + "-nested-after")
}
return result
}
}
}
}

const queuePostbacks: Promise<any>[] =
makeEventRange(parallelism, scheduler, "postback", i =>
postBack(window.document.body, [], "default", "", undefined, [concurrency.parent, postbackHandler("Q" + i), cancerPostbackHandler(scheduler, "Q" + i) ]).catch(_ => {})
)

await waitForEnd(queuePostbacks, scheduler, () => {
expect(state().Property1).toBeLessThanOrEqual(index)
expect(state().Property2).toBeLessThanOrEqual(index2)
})

const numberOfNestedPostbacks = parallelism * (Number(nestedBefore) + Number(nestedAfter))
expect(index).toBeLessThanOrEqual(numberOfNestedPostbacks)
if (concurrency.parent[0] == "concurrency-deny") {
expect(index2).toBeLessThanOrEqual(parallelism)
} else {
// all parallelism requests got to the server
expect(index2).toBe(parallelism)
}

if (concurrency.parent[0] == "concurrency-queue") {
expect(state().Property2).toBe(index2)
expect(index).toBe(numberOfNestedPostbacks)
expect(state().Property1).toBe(index)
}
}
), { timeout: 2000 })
})
Loading