support Linq methods on ImmutableArray + added Errors tab to Compilation Page #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
js-translations-immutablearray
branch
from
7fdcd20 to
b6e30b9
Compare
ImmutableArray is a struct so it has custom Linq method overloads to avoid allocations. These are preferred by the compiler over IEnumerable<T>, so our Linq support was broken. Also added .AsEnumerable and few other conversion methods to help users work around similar issues.
exyi
force-pushed
the
js-translations-immutablearray
branch
from
b6e30b9 to
b5ca605
Compare
tomasherceg
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original goal was to add an "Errors" tab to the compilation which lists all failed pages, controls and master pages. Saves few clicks and scrolling when checking the compilation page.
However, I had to fix Linq translations on
ImmutableArray. ImmutableArray is a struct so it has custom Linq method overloads to avoid allocations. These are preferred by the compiler over theIEnumerable<T>methods.I also added .AsEnumerable and few other conversion methods to help users work around similar issues.