Fix implicit conversion in expressions like C ? P : null
#1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should fix part of #1694
exyi
force-pushed
the
condition-null-implicit-conversion
branch
from
3d44caf to
72dffb2
Compare
tomasherceg
approved these changes
Oct 22, 2023
tomasherceg
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation of ternary expressions with ambiguous conversion (in C?A:B A is convertible to B while B is also convertible to A). This is normally disallowed in C#, but I specifically allowed two cases
objectwhich can be converted to the other type - this occurs if theobjectis nullstringwhich is convertible to the other type - this occurs for our enum constant literalsshould fix part of #1694