Fix whitespace padding width with tabs and Unicode combining characters #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabs are replaced by tabs to preserve the string width, all other characters are replaced by a single space. Moreover we now count the unicode graphemes instead of UTF16 units. It still has the problem that some characters (Emoji, CJK) are wider even in monospace fonts, but that's not that easy to determine.
tomasherceg
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs are replaced by tabs to preserve the string width, all other characters are replaced by a single space. Moreover we now count the unicode graphemes instead of UTF16 units. It still has the problem that some characters (Emoji, CJK) are wider even in monospace fonts, but that's not that easy to determine.
Before:
Now:
The 2 spaces after the emoji is actually a bug in the terminal emulator I use.