Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to BindingParser and PropertyDeclarationDirectiveCompiler #1731

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Improvements to BindingParser and PropertyDeclarationDirectiveCompiler #1731

merged 6 commits into from
Dec 8, 2023

Conversation

Mylan719
Copy link
Contributor

@Mylan719 Mylan719 commented Nov 11, 2023 •
edited
Loading

  • Binding nodes for types now have better defined ranges, in some cases ranges were missing altogether
  • Half written property declaration directive now gets resolved the best it can (before the resolver simply threw the unresolved attributes away)
  • Resolving markup property attributes no longer fails if assigned value is of wrong type (now it reports an error)
  • Fixes in parsing comma separated arguments, before it could not read missing argument. ex: (a, , b , c) or a, b,
  • AssemblyQualifiedName and AssemblyName parser nodes now have correct ranges

@Mylan719 Mylan719 added this to the Version 4.2 milestone Nov 11, 2023
@Mylan719 Mylan719 requested review from tomasherceg and exyi November 11, 2023 01:57
@Mylan719 Mylan719 self-assigned this Nov 11, 2023
@tomasherceg tomasherceg modified the milestones: Version 4.2, Version 4.3 Dec 1, 2023
@Mylan719 Mylan719 force-pushed the property-directive-parser branch from 5e9bd67 to 62ed2d5 Compare December 1, 2023 16:51
Trailing whitespaces discarded from assembly name.
85d2ff4 
Improved AssemblyQualifiedName tests to test ranges.
@exyi exyi merged commit 13f3cf4 into main Dec 8, 2023
12 of 14 checks passed
@exyi exyi deleted the property-directive-parser branch December 8, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exyi exyi exyi approved these changes

@tomasherceg tomasherceg Awaiting requested review from tomasherceg

Assignees

@Mylan719 Mylan719

Labels
enhancement Framework
Projects
None yet
Milestone
Version 4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Mylan719 @exyi @tomasherceg