Attribute value initializer of PropertyDirective changes #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mylan719
force-pushed
the
attribute-initializer-fix
branch
from
4963d4c to
07df42b
Compare
exyi
approved these changes
Jan 7, 2024
| { | ||
| var root = ParseSource(@$" | ||
| @viewModel object | ||
| @property string[] MyProperty=["""",""""], MarkupOptionsAttribute.Required = true, MarkupOptionsAttribute.AllowBinding = false"); |
There was a problem hiding this comment.
You could use the """ string literal to avoid the double-quoting
added 2 commits
January 8, 2024 16:04
exyi
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the initializer of the attribute supports half written values for the VS extension.
The validation before was way too strict and replaced invalid values with empty literal.