Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewmodel restore on back/forward navigation #1848

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

exyi
Copy link
Member

@exyi exyi commented Aug 16, 2024

  • In Firefox, this worked, but also restored it on page reloads
  • In Chromium, viewmodel was always reset to the initial state

This patch unifies the behavior to restore the viewmodel, but not if it is in page reload

@exyi exyi force-pushed the fix-viewmodel-restore branch 2 times, most recently from 8b6325c to 1e6ac4a Compare August 16, 2024 12:02
@exyi exyi added this to the Version 4.3 milestone Aug 17, 2024
@exyi exyi force-pushed the fix-viewmodel-restore branch from 94319f6 to 06f21fe Compare August 17, 2024 22:47
@exyi exyi changed the base branch from main to main-v4 August 17, 2024 22:48
@exyi exyi force-pushed the fix-viewmodel-restore branch from 5302087 to 5f9f48a Compare September 7, 2024 07:54
@tomasherceg tomasherceg merged commit d1825a5 into main-v4 Sep 7, 2024
14 checks passed
@tomasherceg tomasherceg deleted the fix-viewmodel-restore branch September 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants