Fix DotVVM02 warning on overriden ignored property #1858
Merged
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now ignore override properties if the base has JsonIgnore or Bind(None) attribute. Technically, the patch introduces a false negative if the base is ignored and the derived isn't. However, DotVVM behavior regarding this is complex (you cannot override JsonIgnore, only Bind(None)...) and given the rarity of virtual properties, I don't want to unnecesarily complicate the analyzer. fix #1784
tomasherceg
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now ignore override properties if the base has JsonIgnore or Bind(None) attribute.
Technically, the patch introduces a false negative if the base is ignored and the derived isn't. However, DotVVM behavior regarding this is complex (you cannot override JsonIgnore, only Bind(None)...) and given the rarity of virtual properties, I don't want to unnecessarily complicate the analyzer.
fix #1784
I'd release this as a 4.3 patch