Initialized service provider in validation context. #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added simple test. |
tomasherceg
force-pushed
the
Feature/ValidationContextHasServiceProvider
branch
from
359725f to
74dc13f
Compare
exyi
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Ok, thanks for the patch.
Note that the service provider will only work with Singleton services, to allow Scoped and Transient services to work correctly, we'd have to use context.Services instead of config.Services. However, that isn't possible without changing the IViewModelValidator interface, I'd consider doing it later if we want that.
I'll release this one as a 4.3 patch, so you should be able to use the patch soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue reported in #1868.
This change allows users to use complex validation attributes that need access to various services via service provider.