Add info about pre-loading to the Sec-Fetch-Dest GET check #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check that the page is not being loaded with JS, which should prevent attackers from scraping all other pages if they gain access to one. It seems that this check is incompatible with Chrome prefetching (and obviously also any JS-based prefetching). The issue seems to be that Chrome does not know how will the prefetched document be used. According to their documentation, it should ignore prefetch requests with non-2XX status code. Our rejections are 403, so it should not display them to the user.
tomasherceg
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check that the page is not being loaded with
JS, which should prevent attackers from scraping
all other pages if they gain access to one.
It seems that this check is incompatible with Chrome prefetching (and obviously also any JS-based prefetching). The issue seems to be that Chrome does not know
how will the prefetched document be used.
According to their documentation, it should ignore prefetch requests with non-2XX status code.
Our rejections are 403, so it should not display them to the user.