Fixed ambiguous namespace resolution and matching non-public types #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
reviewed
Oct 26, 2024
There was a problem hiding this comment.
10 lines, 10 comments 😅 Anyway, the public type check might be a bit annoying, if someone has all viewmodels internal, which is currently allowed. However, it should be quite simple to migrate and the compilation page will show all the errors, so I think this is a good change for version 5. Alternatively, we could add a list of "InternalsVisibleFrom" assemblies to DotvvmConfiguration, but I guess it is not really worth the added complexity.
I don't know why are the tests failing... more specifically, why the culture whitespace thing stopped being a problem and why tests which don't even exists are failing? 🤦
tomasherceg
force-pushed
the
fix/binding-ambiguous-namespaces
branch
from
32d8396 to
e09359d
Compare
exyi
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1876