Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding translation issue in PostBackHandler properties #1878

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Binding translation issue in PostBackHandler properties #1878

merged 6 commits into from
Oct 31, 2024

Conversation

tomasherceg
Copy link
Member

Referencing _parent in properties of postback handlers is translated to an incorrect JS:

DotHTML:
<dot:SuppressPostBackHandler Suppress="{value: _parent.Enabled}" />

Translated JS:
(c,d) => $parent.Enabled

tomasherceg and others added 2 commits October 26, 2024 13:23
@tomasherceg
Repro for postback handler binding translation issue
468a7ce
@exyi
postbacki handlers: Fix knockout context access in value bindings
60b4226 
Fixes accesses to parent (or higher) knockout contexts or view models.

It is necessary to call the AssignParameters function recursively on default assignments of the parent VM/context parameters.
@exyi exyi force-pushed the bug/postbackhandler-binding-translation branch from 1059afa to 60b4226 Compare October 26, 2024 20:59
@exyi exyi added the bug label Oct 27, 2024
@exyi exyi added this to the Version 4.3 milestone Oct 27, 2024
@exyi exyi merged commit a546262 into main Oct 31, 2024
14 of 15 checks passed
@exyi exyi deleted the bug/postbackhandler-binding-translation branch October 31, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exyi exyi exyi approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasherceg @exyi