Fix Repeater memoization memory leak #1886
Merged
+175
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
fix-Repeater-memory-leak
branch
from
73c55dd to
4bf8213
Compare
tomasherceg
approved these changes
Nov 29, 2024
| [DataRow(DotvvmRequestType.Command, RenderMode.Server)] | ||
| public void Repeater_IsCollectible(DotvvmRequestType requestType, RenderMode renderMode) | ||
| { | ||
| var (repeaterRef, contextRef, viewModelRef) = NewMethod(requestType, renderMode); |
There was a problem hiding this comment.
I am a bit uncomfortable with the method name NewMethod :D
If the ConditionalWeakTable references itself, it will get leaked by .NET Core GC: dotnet/runtime#12255 Fortunately, we don't really need the ConditinalWeakTable here: * Repeater should generally be a short-lived object, so strong references will also be collected reasonably soon * Between Load and PreRender, the viewmodels were pinned in the DataContext of all children and the children are in Children collection. Only after PreRender could those references be useful, but we can as well Clear the dictionary at that point. Co-authored-by: Adam Štěpánek <[email protected]>
exyi
force-pushed
the
fix-Repeater-memory-leak
branch
from
4bf8213 to
eade18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ConditionalWeakTable references itself, it will get leaked by .NET Core GC: dotnet/runtime#12255
Fortunately, we don't really need the ConditinalWeakTable here: