calendar data cleanup

[mgrfilipmarek]

No description provided.

[rine77]

Thanks for contribution!
Tho I dont really get why we remove room here...?

[rine77]

Thanks for contribution!
Tho I dont really get why we remove room here...?

[mgrfilipmarek]

Room is stored in property location, so I don`t see a reason to have it at multiple places.

Thanks for contribution! Tho I dont really get why we remove room here...?

[rine77]

Room is stored in property location, so I don`t see a reason to have it at multiple places.

Thanks for contribution! Tho I dont really get why we remove room here...?

We dont have it in calendar anymore with your change... but: we want the room to be presented in calendar event

[mgrfilipmarek]

Im not sure what you mean that we will not have it anymore. As you can see at the line 135 in the code, there is location=room. And according documentation, there is location attribute in event: https://developers.home-assistant.io/docs/core/entity/calendar/#calendarevent
Before my change, we had room information at two places - in location and also in description. I think, location is correct place to have it.
Screen from current impl with duplicit info (ha developers tools):

[rine77]

Im not sure what you mean that we will not have it anymore.

In calendar we have no room anymore with your change (pic1) and without (pic2)

[mgrfilipmarek]

Ah, ok, now I understand where is the problem.
In standard HA calendar implementation, location is not displayed (this can be considered as bug in ha impl. - https://community.home-assistant.io/t/show-attribute-location-in-calendar-events/628180).

As Im atomic-calendar-revive card, I did not really noticed that its missing in basic calendar.
Btw. I created also WTH post: https://community.home-assistant.io/t/wth-why-calendar-location-property-is-not-displayed/811756.

So I will change the description in feature request a bit and also adjust PR.

[rine77]

Thanks for clearification and work! /rine

…

________________________________ Von: mgrfilipmarek ***@***.***> Gesendet: Montag, 16. Dezember 2024 08:36 An: rine77/homeassistantedupage ***@***.***> Cc: Rene Lange ***@***.***>; Review requested ***@***.***> Betreff: Re: [rine77/homeassistantedupage] calendar data cleanup (PR #62) Ah, ok, now I understand where is the problem. In standard HA calendar implementation, location is not displayed (this can be considered as bug in ha impl. - https://community.home-assistant.io/t/show-attribute-location-in-calendar-events/628180). As Im atomic-calendar-revive card, I did not really noticed that its missing in basic calendar. Btw. I created also WTH post: https://community.home-assistant.io/t/wth-why-calendar-location-property-is-not-displayed/811756. So I will change the description in feature request a bit and also adjust PR. — Reply to this email directly, view it on GitHub<#62 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMBPZONCAJ3RTJGEX26QEHT2FZ7JXAVCNFSM6AAAAABTRVTFFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBUHAYTAMJSHE>. You are receiving this because your review was requested.Message ID: ***@***.***>

[rine77]

nice, thanks!
So we dont have "Unknown" room anymore but no room entry at all.