Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load max_points and percent to grate attributes #63

Merged
merged 2 commits into from
Dec 16, 2024
Merged

load max_points and percent to grate attributes #63

merged 2 commits into from
Dec 16, 2024

Conversation

mgrfilipmarek
Copy link
Collaborator

No description provided.

@mgrfilipmarek mgrfilipmarek linked an issue Dec 13, 2024 that may be closed by this pull request
[feature_request] Grades are not loaded with max points #14
Closed
rine77
rine77 reviewed Dec 15, 2024
View reviewed changes
Copy link
Owner

@rine77 rine77 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I would recommend to only deliver max points and percentage if it's available. In germany for example we dont use this and I guess it's a little unusual :)

image

rine77
rine77 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Owner

@rine77 rine77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rine77 rine77 merged commit 9636b9b into main Dec 16, 2024
4 checks passed
@rine77 rine77 deleted the 14-feature_request-grades-are-not-loaded-with-max-points branch December 16, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rine77 rine77 rine77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature_request] Grades are not loaded with max points
2 participants
@mgrfilipmarek @rine77