Skip to content

Commit

Permalink
Fix wrong currencies method naming
Browse files Browse the repository at this point in the history
  • Loading branch information
Omranic committed Jul 1, 2020
1 parent 20d83d9 commit 2c86453
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 33 deletions.
16 changes: 8 additions & 8 deletions src/CurrencyLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,35 +6,35 @@

class CurrencyLoader
{
protected static $curriencies = [];
protected static $currencies = [];

/**
* Retrive all the curriencies of all countries.
* Retrive all the currencies of all countries.
*
* @param bool $longlist states if need all the details of the curriencies or only the keys
* @param bool $longlist states if need all the details of the currencies or only the keys
*
* @throws \Rinvex\Country\CountryLoaderException
*
* @return array
*/
public static function curriencies($longlist = false): array
public static function currencies($longlist = false): array
{
$list = $longlist ? 'longlist' : 'shortlist';

if (! isset(static::$curriencies[$list])) {
if (! isset(static::$currencies[$list])) {
$countries = CountryLoader::countries($longlist);

foreach ($countries as $country) {
if ($longlist) {
foreach ($country['currency'] as $currency => $details) {
static::$curriencies[$list][$currency] = $longlist ? $details : $currency;
static::$currencies[$list][$currency] = $longlist ? $details : $currency;
}
} else {
static::$curriencies[$list][] = $country['currency'];
static::$currencies[$list][] = $country['currency'];
}
}
}

return static::$curriencies[$list];
return static::$currencies[$list];
}
}
6 changes: 3 additions & 3 deletions src/helpers.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function countries($longlist = false, $hydrate = false)
}
}

if (! function_exists('curriencies')) {
if (! function_exists('currencies')) {
/**
* Get all countries short-listed.
*
Expand All @@ -44,8 +44,8 @@ function countries($longlist = false, $hydrate = false)
*
* @return array
*/
function curriencies($longlist = false)
function currencies($longlist = false)
{
return CurrencyLoader::curriencies($longlist);
return CurrencyLoader::currencies($longlist);
}
}
22 changes: 11 additions & 11 deletions tests/Unit/CurrencyLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,21 @@ class CurrencyLoaderTest extends TestCase
/** @test */
public function it_returns_courrencies_longlist()
{
$this->assertEquals(165, count(CurrencyLoader::curriencies(true)));
$this->assertArrayHasKey('EGP', CurrencyLoader::curriencies());
$this->assertIsArray(CurrencyLoader::curriencies(true)['EGP']);
$this->assertEquals('EGP', CurrencyLoader::curriencies(true)['EGP']['iso_4217_code']);
$this->assertEquals('818', CurrencyLoader::curriencies(true)['EGP']['iso_4217_numeric']);
$this->assertEquals('Egyptian Pound', CurrencyLoader::curriencies(true)['EGP']['iso_4217_name']);
$this->assertEquals('2', CurrencyLoader::curriencies(true)['EGP']['iso_4217_minor_unit']);
$this->assertEquals(165, count(CurrencyLoader::currencies(true)));
$this->assertArrayHasKey('EGP', CurrencyLoader::currencies());
$this->assertIsArray(CurrencyLoader::currencies(true)['EGP']);
$this->assertEquals('EGP', CurrencyLoader::currencies(true)['EGP']['iso_4217_code']);
$this->assertEquals('818', CurrencyLoader::currencies(true)['EGP']['iso_4217_numeric']);
$this->assertEquals('Egyptian Pound', CurrencyLoader::currencies(true)['EGP']['iso_4217_name']);
$this->assertEquals('2', CurrencyLoader::currencies(true)['EGP']['iso_4217_minor_unit']);
}

/** @test */
public function it_returns_courrencies_shortlist()
{
$this->assertEquals(165, count(CurrencyLoader::curriencies()));
$this->assertArrayHasKey('EGP', CurrencyLoader::curriencies());
$this->assertIsString(CurrencyLoader::curriencies()['EGP']);
$this->assertEquals('EGP', CurrencyLoader::curriencies()['EGP']);
$this->assertEquals(165, count(CurrencyLoader::currencies()));
$this->assertArrayHasKey('EGP', CurrencyLoader::currencies());
$this->assertIsString(CurrencyLoader::currencies()['EGP']);
$this->assertEquals('EGP', CurrencyLoader::currencies()['EGP']);
}
}
22 changes: 11 additions & 11 deletions tests/Unit/HelpersTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,21 +126,21 @@ public function it_returns_country_array_shortlist()
/** @test */
public function it_returns_courrencies_longlist()
{
$this->assertEquals(165, count(curriencies(true)));
$this->assertArrayHasKey('EGP', curriencies());
$this->assertIsArray(curriencies(true)['EGP']);
$this->assertEquals('EGP', curriencies(true)['EGP']['iso_4217_code']);
$this->assertEquals('818', curriencies(true)['EGP']['iso_4217_numeric']);
$this->assertEquals('Egyptian Pound', curriencies(true)['EGP']['iso_4217_name']);
$this->assertEquals('2', curriencies(true)['EGP']['iso_4217_minor_unit']);
$this->assertEquals(165, count(currencies(true)));
$this->assertArrayHasKey('EGP', currencies());
$this->assertIsArray(currencies(true)['EGP']);
$this->assertEquals('EGP', currencies(true)['EGP']['iso_4217_code']);
$this->assertEquals('818', currencies(true)['EGP']['iso_4217_numeric']);
$this->assertEquals('Egyptian Pound', currencies(true)['EGP']['iso_4217_name']);
$this->assertEquals('2', currencies(true)['EGP']['iso_4217_minor_unit']);
}

/** @test */
public function it_returns_courrencies_shortlist()
{
$this->assertEquals(165, count(curriencies()));
$this->assertArrayHasKey('EGP', curriencies());
$this->assertIsString(curriencies()['EGP']);
$this->assertEquals('EGP', curriencies()['EGP']);
$this->assertEquals(165, count(currencies()));
$this->assertArrayHasKey('EGP', currencies());
$this->assertIsString(currencies()['EGP']);
$this->assertEquals('EGP', currencies()['EGP']);
}
}

0 comments on commit 2c86453

Please sign in to comment.