chore(deps): bump i18next from 23.4.4 to 23.9.0 (#943)

Bumps [i18next](https://github.com/i18next/i18next) from 23.4.4 to
23.9.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/i18next/i18next/releases">i18next's
releases</a>.</em></p>
<blockquote>
<h2>v23.9.0</h2>
<ul>
<li>types: support nested keys in <code>InterpolationMap</code> <a
href="https://redirect.github.com/i18next/i18next/pull/2140">2140</a>
fixes <a
href="https://redirect.github.com/i18next/i18next/issues/2014">2014</a></li>
</ul>
<h2>v23.8.3</h2>
<ul>
<li>prevent resource mutation when using <code>addResourceBundle</code>
<a
href="https://redirect.github.com/i18next/i18next/issues/2081">2081</a></li>
</ul>
<h2>v23.8.2</h2>
<ul>
<li>optimize <code>addResources</code> to address <a
href="https://redirect.github.com/i18next/i18next/issues/2130">2130</a></li>
</ul>
<h2>v23.8.1</h2>
<ul>
<li>types: support stricter typechecking for returnEmptyString and
returnNull <a
href="https://redirect.github.com/i18next/i18next/pull/2129">2129</a></li>
</ul>
<h2>v23.8.0</h2>
<ul>
<li>improve performance by reducing array slices and RegExp recreation
<a
href="https://redirect.github.com/i18next/i18next/pull/2128">2128</a></li>
</ul>
<h2>v23.7.20</h2>
<ul>
<li>optimize: consistent _zero special handling also for
defaultValue_zero <a
href="https://redirect.github.com/i18next/i18next/issues/2124">2124</a></li>
<li>intl plural rule for dev is now en (consistent with v3
compatibility)</li>
</ul>
<h2>v23.7.19</h2>
<ul>
<li>fix: consistent _zero special handling also for defaultValue_zero <a
href="https://redirect.github.com/i18next/i18next/issues/2124">2124</a></li>
</ul>
<h2>v23.7.18</h2>
<ul>
<li>types: support readonly defaultNS <a
href="https://redirect.github.com/i18next/i18next/pull/2123">2123</a></li>
</ul>
<h2>v23.7.17</h2>
<ul>
<li>types: fix support for defaultNS as array (fixes <a
href="https://redirect.github.com/i18next/i18next/issues/2118">2118</a>)
<a
href="https://redirect.github.com/i18next/i18next/pull/2121">2121</a></li>
<li>types: fix typo in <code>CustomInstanceExtensions</code> <a
href="https://redirect.github.com/i18next/i18next/pull/2122">2122</a></li>
</ul>
<h2>v23.7.16</h2>
<ul>
<li>fix: Use Typescript 5 types with Typescript 5+ <a
href="https://redirect.github.com/i18next/i18next/pull/2108">2108</a>
<ul>
<li>Hint: If you're using TypeScript 4 and you navigate to the type
definitions in your code editor, it might be you will see the TypeScript
5 types, but the TS compiler should use the correct types.</li>
</ul>
</li>
</ul>
<h2>v23.7.15</h2>
<ul>
<li>types: simplifies types for array access and fixes <a
href="https://redirect.github.com/i18next/i18next/issues/2103">2103</a></li>
</ul>
<h2>v23.7.14</h2>
<ul>
<li>types: fix types for array access</li>
</ul>
<h2>v23.7.13</h2>
<ul>
<li>types: optimise ParseTReturn <a
href="https://redirect.github.com/i18next/i18next/pull/2095">2095</a></li>
</ul>
<h2>v23.7.12</h2>
<ul>
<li>types: fix for older ts version (context validation only for TS
5)</li>
</ul>
<h2>v23.7.11</h2>
<ul>
<li>types: fix for older ts versions <a
href="https://redirect.github.com/i18next/i18next/issues/2090">2090</a></li>
</ul>
<h2>v23.7.10</h2>
<ul>
<li>types: initializedStoreOnce and initializedLanguageOnce <a
href="https://redirect.github.com/i18next/i18next/pull/2089">2089</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/i18next/i18next/blob/master/CHANGELOG.md">i18next's
changelog</a>.</em></p>
<blockquote>
<h2>23.9.0</h2>
<ul>
<li>types: support nested keys in <code>InterpolationMap</code> <a
href="https://redirect.github.com/i18next/i18next/pull/2140">2140</a>
fixes <a
href="https://redirect.github.com/i18next/i18next/issues/2014">2014</a></li>
</ul>
<h2>23.8.3</h2>
<ul>
<li>prevent resource mutation when using <code>addResourceBundle</code>
<a
href="https://redirect.github.com/i18next/i18next/issues/2081">2081</a></li>
</ul>
<h2>23.8.2</h2>
<ul>
<li>optimize <code>addResources</code> to address <a
href="https://redirect.github.com/i18next/i18next/issues/2130">2130</a></li>
</ul>
<h2>23.8.1</h2>
<ul>
<li>types: support stricter typechecking for returnEmptyString and
returnNull <a
href="https://redirect.github.com/i18next/i18next/pull/2129">2129</a></li>
</ul>
<h2>23.8.0</h2>
<ul>
<li>improve performance by reducing array slices and RegExp recreation
<a
href="https://redirect.github.com/i18next/i18next/pull/2128">2128</a></li>
</ul>
<h2>23.7.20</h2>
<ul>
<li>optimize: consistent _zero special handling also for
defaultValue_zero <a
href="https://redirect.github.com/i18next/i18next/issues/2124">2124</a></li>
<li>intl plural rule for dev is now en (consistent with v3
compatibility)</li>
</ul>
<h2>23.7.19</h2>
<ul>
<li>fix: consistent _zero special handling also for defaultValue_zero <a
href="https://redirect.github.com/i18next/i18next/issues/2124">2124</a></li>
</ul>
<h2>23.7.18</h2>
<ul>
<li>types: support readonly defaultNS <a
href="https://redirect.github.com/i18next/i18next/pull/2123">2123</a></li>
</ul>
<h2>23.7.17</h2>
<ul>
<li>types: fix support for defaultNS as array (fixes <a
href="https://redirect.github.com/i18next/i18next/issues/2118">2118</a>)
<a
href="https://redirect.github.com/i18next/i18next/pull/2121">2121</a></li>
<li>types: fix typo in <code>CustomInstanceExtensions</code> <a
href="https://redirect.github.com/i18next/i18next/pull/2122">2122</a></li>
</ul>
<h2>23.7.16</h2>
<ul>
<li>fix: Use Typescript 5 types with Typescript 5+ <a
href="https://redirect.github.com/i18next/i18next/pull/2108">2108</a>
<ul>
<li>Hint: If you're using TypeScript 4 and you navigate to the type
definitions in your code editor, it might be you will see the TypeScript
5 types, but the TS compiler should use the correct types.</li>
</ul>
</li>
</ul>
<h2>23.7.15</h2>
<ul>
<li>types: simplifies types for array access and fixes <a
href="https://redirect.github.com/i18next/i18next/issues/2103">2103</a></li>
</ul>
<h2>23.7.14</h2>
<ul>
<li>types: fix types for array access</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/i18next/i18next/commit/f66289e1a2365c602239b19ea70542caa89dba76"><code>f66289e</code></a>
23.9.0</li>
<li><a
href="https://github.com/i18next/i18next/commit/9d1d4ef48b5d763c5e971d16e115f036639a7656"><code>9d1d4ef</code></a>
release</li>
<li><a
href="https://github.com/i18next/i18next/commit/d7577a9a07d4eafb399f5407a805e865b16283a2"><code>d7577a9</code></a>
types: support nested keys in <code>InterpolationMap</code> (<a
href="https://redirect.github.com/i18next/i18next/issues/2140">#2140</a>)</li>
<li><a
href="https://github.com/i18next/i18next/commit/2f3384ba5bf7422e387d320f3a347cf3d28e417a"><code>2f3384b</code></a>
23.8.3</li>
<li><a
href="https://github.com/i18next/i18next/commit/d2d7608539f359060f456909f62eb958246f08de"><code>d2d7608</code></a>
prevent resource mutation when using <code>addResourceBundle</code>
fixes <a
href="https://redirect.github.com/i18next/i18next/issues/2081">#2081</a></li>
<li><a
href="https://github.com/i18next/i18next/commit/4ce76aec6301506bd9a792ff39ecd009ff7598c2"><code>4ce76ae</code></a>
23.8.2</li>
<li><a
href="https://github.com/i18next/i18next/commit/002268b0249a3670367d8f2d65bd7e665712036b"><code>002268b</code></a>
optimize <code>addResources</code> to fix <a
href="https://redirect.github.com/i18next/i18next/issues/2130">#2130</a></li>
<li><a
href="https://github.com/i18next/i18next/commit/70591073b81298c158017950f8b9626fc0ed3608"><code>7059107</code></a>
23.8.1</li>
<li><a
href="https://github.com/i18next/i18next/commit/3b5f55d974d35ccfa50093861ab90021a0395ca0"><code>3b5f55d</code></a>
release</li>
<li><a
href="https://github.com/i18next/i18next/commit/0aef9248f2092e409166bf3d57c2fad6dc3a3087"><code>0aef924</code></a>
Support stricter typechecking for returnEmptyString and returnNull (key
fallb...</li>
<li>Additional commits viewable in <a
href="https://github.com/i18next/i18next/compare/v23.4.4...v23.9.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=i18next&package-manager=npm_and_yarn&previous-version=23.4.4&new-version=23.9.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Phu Pham <[email protected]>
Co-authored-by: pdp2121 <[email protected]>

package.json

@@ -28,7 +28,7 @@
     "esbuild": "^0.19.8",
     "events": "^3.3.0",
     "express": "^4.18.2",
-    "i18next": "^23.4.4",
+    "i18next": "^23.9.0",
     "i18next-browser-languagedetector": "^7.1.0",
     "i18next-http-backend": "^2.2.1",
     "prop-types": "^15.8.1",

src/containers/Amendment/Votes.tsx

@@ -43,7 +43,10 @@ export const Votes = ({ data, validators }: VotesProps) => {
 
   const voting = data.voted !== undefined
 
-  const renderColumn = (label: string, validatorsList: Array<validatorUNL>) => (
+  const renderColumn = (
+    label: 'yeas' | 'nays',
+    validatorsList: Array<validatorUNL>,
+  ) => (
     <div className={`votes-column ${label}`}>
       <div className="label">{t(label)}</div>
       <div className="vals">

src/containers/Ledgers/LedgerMetrics.tsx

@@ -99,7 +99,9 @@ export const LedgerMetrics = ({
 
       return (
         <div className="cell" key={key}>
-          <div className={className}>{t(key)}</div>
+          <div className={className}>
+            {t(key, { defaultValue: 'load_fee' })}
+          </div>
           <span>{content}</span>
         </div>
       )

src/containers/shared/components/Transaction/AMMDelete/TableDetail.tsx

@@ -12,7 +12,7 @@ export const TableDetail = ({
   return (
     <div className="ammDelete">
       <div data-test="asset">
-        <span className="label">{t('asset')}</span>
+        <span className="label">{t('asset1')}</span>
         <Currency currency={Asset.currency} issuer={(Asset as any).issuer} />
       </div>
       <div data-test="asset2">

src/containers/shared/components/Transaction/AMMDelete/test/AMMDeleteTableDetail.test.tsx

@@ -9,7 +9,7 @@ describe('AMMDelete: TableDetail', () => {
   it('renders with an expiration and offer', () => {
     const wrapper = createWrapper(mockAMMDelete)
 
-    expect(wrapper.find('[data-test="asset"]')).toHaveText('asset\uE900 XRP')
+    expect(wrapper.find('[data-test="asset"]')).toHaveText('Asset 1\uE900 XRP')
     expect(wrapper.find('[data-test="asset2"]')).toHaveText(
       'Asset 2FOO.rm5c42Crqpdch5fbuCdHmSMV1wrL9arV9',
     )