Draft: Add Credentials Support #1118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## High Level Overview of Change Fix typo for website in english translation ### Context of Change Bug introduced in #1056 ### Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ### TypeScript/Hooks Update - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript
achowdhry-ripple
changed the title
achowdhry-ripple
changed the title
mvadari
reviewed
Jan 14, 2025
Comment on lines
18
to
23
| {convertHexToString(Account)} | ||
| </SimpleRow> | ||
| )} | ||
| {Issuer && ( | ||
| <SimpleRow label={t('issuer')} data-test="issuer"> | ||
| {convertHexToString(Issuer)} |
There was a problem hiding this comment.
Account and Issuer aren't hex
mvadari
reviewed
Jan 14, 2025
|
|
||
| export const CredentialAcceptTransaction: TransactionMapping = { | ||
| Simple, | ||
| action: TransactionAction.ACCEPT, |
There was a problem hiding this comment.
I would use MODIFY instead of creating a new type just for this
achowdhry-ripple
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
TypeScript/Hooks Update
Before / After
Test Plan