Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Misaligned Stores with Page Fault to partially succeed #1119

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Allow Misaligned Stores with Page Fault to partially succeed #1119

merged 1 commit into from
Sep 27, 2023

Conversation

ingallsj
Copy link
Contributor

@ingallsj ingallsj commented Sep 7, 2023

  1. Extend the >XLEN decomposition relaxation to vector stores by deleting the word “floating-point” in the description of PMP faults.
  2. Add similar text copied from the PMP section to the Sv32 section for virtual memory page faults.

This is just a clarification, since it follows logically from misaligned accesses possibly being decomposed into smaller accesses.
"Notably, instructions that reference virtual memory are decomposed into multiple accesses."

@aswaterman
Copy link
Member

cc @gfavor — this is already the case (it follows from the legality of decomposing misaligned accesses, as might be the case in HW and is definitely the case in trap-and-emulate), but this makes it explicit with respect to the virtual-memory system. OK to merge?

@allenjbaum
Copy link

allenjbaum commented Sep 8, 2023 via email

@aswaterman
Copy link
Member

@allenjbaum Also FSD+NA4 (for RV32 with G=0), and also FSQ+TOR (for RV32 or RV64 with G <= 1). It's a little ungainly to exhaustively specify.

@gfavor Since this has marinated a while, and it's just a clarification (due to the rule that accesses can be decomposed down to the byte level to facilitate emulation), I'm going to merge it as-is. LMK if you have any concerns after the fact.

@aswaterman aswaterman merged commit 1ee25e1 into riscv:main Sep 27, 2023
2 checks passed
@gfavor
Copy link
Collaborator

gfavor commented Sep 28, 2023

Yes, this is fine.

@allenjbaum
Copy link

Agreed. I'd love a bit more clarity on the order of those accesses, which is what really makes it complicated, but we've discussed that. We'll deal with deterministic cases, but someday I suspect we will need to deal with it just like the vector spec does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants