-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Smctr/Sscctr #1615
Add Smctr/Sscctr #1615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two changes here LGTM, however, don't forget to add the include::smctr.adoc to riscv-privileged.adoc.
Good catch! Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really 1.0 given that it hasn't been ratified? I think the options are to leave the PR unmerged until ratification, or to decrement the version number and add the Frozen warning.
Also, don't forget to update the extension list in the preface.
Definitely not 1.0 yet. I assumed this PR was going to sit around until the extension is ratified, so v1.0 was appropriate. Do we normally merge frozen but not ratified extensions into the ISA manual? If so I can modify this. |
I think either way is OK. Leaving this PR alone until ratification is the minimal-effort thing, so if you're OK with that, let's do that. |
I updated the preface, again as though the extensions are ratified. We'll wait until ratification to merge. |
…06306274c1 in the ctr repo
d04292c
to
764f17b
Compare
Signed-off-by: Beeman Strong <[email protected]>
I believe this PR is ready to merge. CTR is ratified (v1.0), and I pushed some late clarifications that were added to the CTR repo. I removed any mention of CTR from the preface, since those entries seem to be made when a new release is released. I don't know when that will be, so I assume @wmat will create that. @aswaterman you had a change request related to this, please either approve or let me know if a change is still needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bcstrongx!
Not yet ratified, going to TSC vote soon.