-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhc] support for multiple Python versions #299
Conversation
06672a9
to
6fa646b
Compare
@aswaterman and @Myrausman, I would also like to mention one point here regarding the older python versions. The concerns comes from the commit python 3..6 compatibility. We should also give a look as what impact the existing codes have on older versions as well and by adopting the newer ones. |
Thank you for your feedback, @IIITM-Jay. I'll certainly delve deeper into the potential implications of our existing code on older Python versions. I'm encountering a minor challenge with my GitHub Action workflow. While attempting to utilize Python 3.6, I'm receiving the error Could you please provide some guidance on how to resolve this issue? |
Oh! I see, Sorry for the delayed response! @aswaterman and @Myrausman , The error that you are facing with this PR currently is that But, if we really want to test against
|
@aswaterman , few more suggestions:
Thinking to do above related things in a separate PR elaborating each steps and the reasons why we are adopting those |
I wonder should the python parser separates from this repo as a standalone project? Originally, it was simple. But recently the trend of it seems to grow into some big project that even needs multiple python versions support. It’s kinda unbelievable for such a simple project. IMHO, the change to parser logic is always unrelated to the opcodes itself, and seldom does the opcode changes(only add new instructions and move ops from unratified). I think we maybe can formally define the syntax of opcodes and move the parser logic to another repo if the python parser is too mutable. |
I'm OK with ditching support for Python 3.6, so we can revise this PR to only test against 3.8 and above if that's what we decide is best. And I support any sensible improvements to improve the extent of our CI or speed it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Myrausman I have left some comments to revise this PR.
@aswaterman I think it would be good to showcase with the help of this CI setup that this repository is in-line with all the current supported versions of Python 3.x
, which are having longer EOL, considering the fact that we can have users of this repo having other supported versions of Python
on their systems and not just the latest one. I am taking the reference from the Current Status of Python versions , to revise this PR.
a5dd6f5
to
f8f347c
Compare
@Myrausman as per @rpsene, we would be doing these for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it as it shows merging is blocked until the requested changes are being addressed (as I only requested for those changes).
@aswaterman needed your suggestions to go ahead. What do you think for the support of the other python versions
mentioned in this PR.
Signed-off-by: Myrausman <[email protected]>
Signed-off-by: Jay Dev Jha <[email protected]>
* Refactor GitHub Actions workflow to support multiple Python versions Signed-off-by: Myrausman <[email protected]> * CI improvements * MInor update python-app.yml Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Myrausman <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
* Refactor GitHub Actions workflow to support multiple Python versions Signed-off-by: Myrausman <[email protected]> * CI improvements * MInor update python-app.yml Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Myrausman <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
* Refactor GitHub Actions workflow to support multiple Python versions Signed-off-by: Myrausman <[email protected]> * CI improvements * MInor update python-app.yml Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Myrausman <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
* Refactor GitHub Actions workflow to support multiple Python versions Signed-off-by: Myrausman <[email protected]> * CI improvements * MInor update python-app.yml Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Myrausman <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
* Refactor GitHub Actions workflow to support multiple Python versions Signed-off-by: Myrausman <[email protected]> * CI improvements * MInor update python-app.yml Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Myrausman <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
* Refactor GitHub Actions workflow to support multiple Python versions Signed-off-by: Myrausman <[email protected]> * CI improvements * MInor update python-app.yml Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Myrausman <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
Refactored GitHub Actions workflow to support multiple Python versions