Skip to content

Commit

Permalink
Merge pull request #110 from riscv/ml-fb/allenbaum
Browse files Browse the repository at this point in the history
address feedback from allen baum on mailing list dated oct 29, 2024
  • Loading branch information
rsahita authored Nov 5, 2024
2 parents 0850e6f + 5cac227 commit 706403a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion chapter2.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ The following normative architecture extensions are defined.

* `Smsdid` (<<Smsdid>>) - An interface to program the active supervisor domain
under which a hart is operating. This is a dynamic control state on the hart
that can be held in an M-mode CSR and modifiable by the RDSM via CSR r/w
that is held in an M-mode CSR and modifiable by the RDSM via CSR r/w
instructions - herewith called the `supervisor domain identifier` assigned to
the hart. The SDID is a local identifier for the hart and may be used to tag
hart-local resources to access-control data associated with the supervisor
Expand Down
9 changes: 5 additions & 4 deletions chapter3.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ addresses with RWX permissions per page

Implementations are not required to support all defined `MODE` settings when
`XLEN=64`. A write to `mmpt` with an unsupported `MODE` value is not ignored.
Instead, the fields of `mmpt` are `WARL` in the normal way, when so indicated.
Instead, the fields of `mmpt` are `WARL` in the normal way, when so indicated
in <<sdid-32>> and <<sdid-64>>.

The `mmpt.PPN` refers to an `MPTL3` table or an `MPTL2` table based on physical
address width (`PAW`). For 56 >= `PAW` > 46, `MPTL3` table must be of size
Expand Down Expand Up @@ -196,9 +197,9 @@ domain access-permissions with current execution.
`MFENCE.SPA` is only valid in M-mode. If operand rs1≠x0, it
specifies a single physical address, and if rs2≠x0, it specifies a single SDID.

If rs1 corresponds to an `MPT_L1_DIR` mapping, the fence applies to
a 4 KiB page. If rs1 corresponds to a `2M_PAGES` or `4M_PAGES` mapping,
the fence applies to a 2 MiB or 4 MiB range. If rs1 corresponds to one
If the address in rs1 corresponds to an `MPT_L1_DIR` mapping, the fence applies to
a 4 KiB page. If the address in rs1 corresponds to a `2M_PAGES` or `4M_PAGES` mapping,
the fence applies to a 2 MiB or 4 MiB range. If the address in rs1 corresponds to one
of the 1G_* mappings, the fence applies to a 1 GiB range.

The behavior of `MFENCE.SPA` depends on rs1 and rs2 as follows:
Expand Down
2 changes: 1 addition & 1 deletion chapter4.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ address (SPA) is used to index into the `MPT` structure in memory to lookup
access permissions for the supervisor domain specified via the MPT structures.
Intermediate `MPTL3` and `MPTL2` non-leaf entries are used to allow this
structure to be sparsely populated. The `MPTL3` table is not applicable for
physical address widths <= 46.
physical address widths \<= 46.

[caption="Figure {counter:image}: ", reftext="Figure {image}"]
[title= "`MPT` walk for RV64", id=mpt-map-rv64]
Expand Down

0 comments on commit 706403a

Please sign in to comment.